Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(css/parser): Fix parsing of :global(> *) #7082

Merged
merged 13 commits into from
Mar 16, 2023
Merged

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Mar 15, 2023

Description:

Related issue (if exists):

@kdy1 kdy1 added this to the Planned milestone Mar 15, 2023
Copy link
Member Author

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_css_parser

@kdy1 kdy1 changed the title fix(css/parser): Fix bugs fix(css/parser): Fix parsing of global(> *) Mar 15, 2023
@kdy1 kdy1 changed the title fix(css/parser): Fix parsing of global(> *) fix(css/parser): Fix parsing of :global(> *) Mar 15, 2023
@kdy1 kdy1 marked this pull request as ready for review March 15, 2023 07:13
@@ -0,0 +1,3 @@
.__local__quickstart .__local__buttons > * {
Copy link
Contributor

@alexander-akait alexander-akait Mar 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is extra space and looks like we can cut them more, but it is not critical, I will refactor the whole logic on better perf and more readable logic and will fix it

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thank you!

@kdy1 kdy1 merged commit 60f74ea into swc-project:main Mar 16, 2023
@kdy1 kdy1 deleted the css-fix branch March 16, 2023 02:17
@kdy1 kdy1 modified the milestones: Planned, v1.3.41 Mar 17, 2023
@swc-project swc-project locked as resolved and limited conversation to collaborators Apr 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants